Conversation
Iterations from end-to-end testing against a live Postmark account: - Surface persistent error banners for sendTestEmail and testConnection failures (toasts auto-dismissed too quickly to read full Postmark API errors). - Move "Make active provider" button up next to the alert banner so the required action is immediately actionable instead of buried at the bottom of the form. - Group "Test connection" with the picker refresh buttons under a shared divider — they're all API health-check actions. - Fix stats widget rendering crash: Block Kit's StatsBlock expects `items: StatItem[]`, not `stats: ...` (Block Kit reference doc was misleading). - Rename widget metric "Submitted" → "Sent" to match Postmark's own dashboard vocabulary. - Add "Failed" stat card and a red `#DC2626` chart series so Postmark API rejections are visually distinct from recipient bounces. - Hide the "Opened" stat card when Track opens is disabled — same for the "Opens" column in the recent deliveries table — so disabled metrics don't add noise. - Sent metric now counts only rows with status=="sent" (in-flight or terminal-when-no-webhook), not all attempts. Previous behavior conflated the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI polish from end-to-end testing of v0.1.0 against a live Postmark account.
Send test emailandTest connectionfailures — toasts auto-dismissed too quickly to read full Postmark API errors.StatsBlockexpectsitems: StatItem[], notstats: ...(the reference doc was misleading).Submitted→Sentto match Postmark's own dashboard vocabulary.Failedstat card and red#DC2626chart series so Postmark API rejections are visually distinct from recipient bounces.Openedstat card andOpenstable column when Track opens is off, so disabled metrics don't add noise.Sentmetric now counts onlystatus === "sent"(in-flight, or terminal when no webhook). Previous behavior conflated "in-flight" with "all attempts."Test plan
pnpm typecheck— cleanpnpm test— 110/110 passpnpm build— clean