Prepare v0.1.0 npm release: capability rename + admin route fix#3
Merged
Prepare v0.1.0 npm release: capability rename + admin route fix#3
Conversation
- Rename capabilities to non-deprecated names: `email:provide` → `hooks.email-transport:register`, `network:fetch` → `network:request`. Bumps peerDependency to `emdash >= 0.9.0`. - Move `docs/icon.png` to repo root so `emdash plugin bundle` picks it up automatically (it looks for `icon.png` and `screenshots/` next to package.json). - Add `icon.png` and `screenshots` to the `files` array so the npm tarball ships them too; explicit `publishConfig.access: public`; `prepublishOnly` now runs `pnpm run build` for consistency with the workspace toolchain. - Add `.github/workflows/release.yml` triggered on tag push (`v*`). Order: build → npm publish → bundle marketplace tarball → marketplace publish (`--no-wait`) → GitHub Release with bundle as asset. Requires secrets: `NPM_TOKEN` (Automation), `EMDASH_MARKETPLACE_TOKEN`.
- Remove "Bundle marketplace tarball" + "Publish to EmDash Marketplace" steps and the bundle asset from the GitHub Release. Marketplace publishing is too beta to gate v0.1.0 on; release.yml now does npm publish + GitHub Release only. EMDASH_MARKETPLACE_TOKEN secret is no longer required. - adminHandler now matches `/settings`, `/`, and `""` for the page_load interaction so the plugin root URL (`/_emdash/admin/plugins/postmark`) renders the settings page. Previously only `/settings` matched, which left the plugin root blank in admin builds whose gear-icon link drops the splat.
drudge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up tag-triggered npm publishing for v0.1.0. Marketplace publishing is intentionally deferred — that flow is too beta to gate v0.1.0 on.
emdash >= 0.9.0:email:provide→hooks.email-transport:registernetwork:fetch→network:requestpeerDependencies.emdashbumped from>=0.7.0to>=0.9.0./settings,/, and""forpage_load. Previously only/settingsmatched, which left the plugin root blank when the host admin's "Settings" gear icon linked to/_emdash/admin/plugins/postmark(no splat).docs/icon.pngtoicon.png(repo root) and added tofiles. (Useful for the npm README on npmjs.com; was originally for the marketplace bundle, which is now skipped.)package.jsonpolish: explicitpublishConfig.access: public;filesincludesicon.pngandscreenshots;prepublishOnlyrunspnpm run build..github/workflows/release.ymltriggered onv*tag pushes. Order: install → typecheck → test:coverage → build → version-vs-tag check → npm publish → GitHub Release.Required before tagging v0.1.0
NPM_TOKENsecret at https://github.com/drudge/emdash-plugin-postmark/settings/secrets/actions — npm Automation token (Access Tokens → Generate New Token → Automation), required if 2FA-on-writes is enforced.main:git tag -a v0.1.0 -m "v0.1.0" && git push origin v0.1.0— release.yml fires.Deferred (not blocking v0.1.0)
emdash plugin publish.screenshots/— would be nice for npm README on npmjs.com but not required to ship.Test plan
pnpm typecheck— cleanpnpm test:coverage— 112/112 passingpnpm build— clean, ~12kB gzipped outputpnpm pack— npm tarball includesicon.png,dist/, README, CHANGELOG, LICENSE/_emdash/admin/plugins/postmarknow renders the settings page (verified after install in test-site)