SyncEmailTemplates: added count check #93
Conversation
|
@matllubos @zamazaljiri pls review |
pymess/utils/migrations.py
Outdated
| email_template_list = list(email_template_qs) | ||
| if self.template_slugs: | ||
| assert len(email_template_list) == len(self.template_slugs), \ | ||
| "The count of email templates given does not match the count of templates found" |
There was a problem hiding this comment.
I don't like it. Which templates was not found? It can be hard to find the right one.
There was a problem hiding this comment.
I don't remember the exact template name. I created a migration and unintentionally made a typo in a template name:
operations = [
migrations.RunPython(SyncEmailTemplates((
'typo-in-template-name',
))),
]Then I couldn't figure out why the template is not syncing after "successful" migration run. If there was this assert then it would be much easier to find a problem.
There was a problem hiding this comment.
Do you think there's a valid usage of SyncEmailTemplates when len(email_template_list) == len(self.template_slugs) is not True?
There was a problem hiding this comment.
Yes but you should return which slug was not found...
There was a problem hiding this comment.
ok. I have changed that:
...
File "/usr/local/lib/python3.9/site-packages/django/db/migrations/operations/special.py", line 190, in database_forwards
self.code(from_state.apps, schema_editor)
File "/usr/local/lib/python3.9/site-packages/pymess/utils/migrations.py", line 29, in __call__
assert not email_templates_not_found, f"Email templates {email_templates_not_found} were not found."
AssertionError: Email templates {'non-existent'} were not found.
jsilhan
force-pushed
the
sync-email-check-count
branch
2 times, most recently
from
ea4c41a to
e89d3a1
Compare
jsilhan
force-pushed
the
sync-email-check-count
branch
from
e89d3a1 to
76b8b9e
Compare
2 participants
No description provided.