fix: MCD-993: Use page.waitForFunction for hydration helpers#41
Merged
Conversation
Replace page.evaluate-based hydration waits with page.waitForFunction, which survives within-document navigations (history.replaceState) that Vue Router fires during SSR hydration.
fago
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.evaluate-based hydration waits withpage.waitForFunctioninwaitForNuxtHydrationandwaitForNuxtToBeReadywaitForFunctionsurvives execution-context destruction caused by Vue Router'shistory.replaceState()during SSR hydrationfrontend-gallery-hash-navigationspec on LDP 25.x CI (~43% failure rate)Root cause
Vue Router calls
history.replaceState()during SSR hydration to inject route state. Chrome firesPage.navigatedWithinDocumentwhich destroys Playwright's evaluate execution context.page.evaluatewith a long-lived Promise dies;page.waitForFunctionre-evaluates across context transitions by design.Confirmed via CDP instrumentation on CI (captured
navigationType: "historyApi"event 10ms before the evaluate error).Test plan
🤖 Generated with Claude Code