Skip to content

Use drupal-core-strict.#264

Closed
greg-1-anderson wants to merge 3 commits intodrupal-composer:8.xfrom
greg-1-anderson:drupal-core-strict
Closed

Use drupal-core-strict.#264
greg-1-anderson wants to merge 3 commits intodrupal-composer:8.xfrom
greg-1-anderson:drupal-core-strict

Conversation

@greg-1-anderson
Copy link
Copy Markdown
Collaborator

With the current twig regression, Composer-managed Drupal sites will get a too-recent version of Twig, and experience problems.

Should we perhaps prevent this by using the webflo/drupal-core-strict project? Seems to work well and solve the problem.

@greg-1-anderson
Copy link
Copy Markdown
Collaborator Author

Haven't analyzed why dependency resolution doesn't succeed. Worked in pantheon-systems/example-drops-8-composer#75.

@webflo
Copy link
Copy Markdown
Member

webflo commented Apr 13, 2017

Related to composer/composer#6131 and composer/composer#6139

@greg-1-anderson
Copy link
Copy Markdown
Collaborator Author

That's odd. As I mention above, pantheon-systems/example-drops-8-composer#75 is working, and that project is a derivative of this project. I don't know what the difference is.

@webflo
Copy link
Copy Markdown
Member

webflo commented Apr 14, 2017

I build a new package, which has drupal/core as a dependency. I hope it helps to resolve the dependencies in a reliable way.

@greg-1-anderson
Copy link
Copy Markdown
Collaborator Author

This looks good to me. If drupal-core-strict requires drupal-core, then should we advise that it be used in place of, instead of in addition to, drupal-core in a project's composer.json?

I don't know if it makes any difference to Composer, but it seems logical.

@webflo
Copy link
Copy Markdown
Member

webflo commented Apr 14, 2017

I think having it in addition is fine, because its an optional package. The DX is not ideal, its makes updates via composer difficult due the related composer issues.

@webflo
Copy link
Copy Markdown
Member

webflo commented Jun 26, 2018

Lets keep it optional. It will hurt DX a lot. webflo/drupal-core-require-dev causes enough confusion for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants