Skip to content

Improve structure#58

Merged
zaporylie merged 8 commits intomasterfrom
improve-structure
Sep 28, 2016
Merged

Improve structure#58
zaporylie merged 8 commits intomasterfrom
improve-structure

Conversation

@zaporylie
Copy link
Copy Markdown
Member

I decided to simplify repo structure and combine all Dockerfiles for single PHP branch into one folder.

Pros:

  • less folders - less mess
  • shared config files (drupal-*.ini) - huge benefit!

Cons:

  • when you build image manually you have to provide filename for Dockerfile, ex. docker build -f ./5.6/Dockerfile-cli -t local/php:5.6-cli ./5.6
  • for all the cli images we have to first set defaults and then override it with cli-specific overrides

IMHO the pros are over the cons and that PR should be merged into master.

@zaporylie
Copy link
Copy Markdown
Member Author

Calling @slashrsm: I would appreciate your review!

https://github.com/drupal-docker/php/tree/improve-structure

Copy link
Copy Markdown
Contributor

@slashrsm slashrsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zaporylie zaporylie merged commit 80f6003 into master Sep 28, 2016
@zaporylie zaporylie deleted the improve-structure branch September 28, 2016 13:12
@zaporylie zaporylie mentioned this pull request Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants