Removed all WhiteSpace Rules out of phpcs.xml.dist#1059
Merged
klausi merged 11 commits intodrupal-graphql:8.x-4.xfrom Aug 10, 2020
Merged
Removed all WhiteSpace Rules out of phpcs.xml.dist#1059klausi merged 11 commits intodrupal-graphql:8.x-4.xfrom
klausi merged 11 commits intodrupal-graphql:8.x-4.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #1059 +/- ##
==========================================
Coverage 50.38% 50.38%
Complexity 683 683
==========================================
Files 118 118
Lines 1820 1820
==========================================
Hits 917 917
Misses 903 903
Continue to review full report at Codecov.
|
Dylan203
changed the title
klausi
requested changes
Aug 10, 2020
Contributor
klausi
left a comment
klausi
left a comment
There was a problem hiding this comment.
cool, just some small things we should improve
| * @covers \Drupal\graphql\Plugin\GraphQL\DataProducer\XML\XMLAttribute::resolve | ||
| */ | ||
| /** | ||
| * @covers \Drupal\graphql\Plugin\GraphQL\DataProducer\XML\XMLAttribute::resolve |
Contributor
There was a problem hiding this comment.
this line should not be changed, the star should be under the first star.
| */ | ||
| /** | ||
| * @covers \Drupal\graphql\Plugin\GraphQL\DataProducer\XML\XMLAttribute::resolve | ||
| */ |
| $this->mockResolver('Tree', 'name', $this->builder->cond([ | ||
| [$this->builder->fromValue(FALSE), $this->builder->fromValue('This should not be in the result.')], | ||
| [function () { return new Deferred(function () { return TRUE; }); }, $this->builder->fromValue('But this should.')], | ||
| [function () {return new Deferred(function () {return TRUE; |
Contributor
There was a problem hiding this comment.
let's format these return statements on the next lines with 2 space additional indentation.
| [function () {return new Deferred(function () {return TRUE; | ||
| }); | ||
| }, $this->builder->fromValue('But this should.') | ||
| ], |
Contributor
There was a problem hiding this comment.
should be indented to the current level in the array
klausi
requested changes
Aug 10, 2020
Contributor
klausi
left a comment
klausi
left a comment
There was a problem hiding this comment.
please also format the other return statements.
| [function () { return new Deferred(function () { return TRUE; }); }, $this->builder->fromValue('But this should.')], | ||
| [function () { | ||
| return new Deferred(function () { | ||
| return TRUE; |
Contributor
There was a problem hiding this comment.
indentation should always be 2 spaces for a new level
| $this->mockResolver('Tree', 'name', $this->builder->defaultValue( | ||
| $this->builder->callback(function () { return new Deferred(function () { return NULL; }); }), | ||
| $this->builder->callback(function () { return new Deferred(function () { return 'bar'; }); }) | ||
| $this->builder->callback(function () {return new Deferred(function () {return NULL; |
Contributor
There was a problem hiding this comment.
same here, please split up the return statements
| $this->mockResolver('Tree', 'uri', $this->builder->defaultValue( | ||
| $this->builder->callback(function () { return new Deferred(function () { return 'baz'; }); }), | ||
| $this->builder->callback(function () { return new Deferred(function () { return 'bar'; }); }) | ||
| $this->builder->callback(function () {return new Deferred(function () {return 'baz'; |
Contributor
There was a problem hiding this comment.
same here, please split up the return statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exclude name="Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace"
exclude name="Drupal.WhiteSpace.Comma.NoSpace"
exclude name="Drupal.WhiteSpace.Comma.TooManySpaces"
exclude name="Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace"
exclude name="Drupal.WhiteSpace.OpenTagNewline.BlankLine"
exclude name="Drupal.WhiteSpace.ScopeClosingBrace.Line"
exclude name="Drupal.WhiteSpace.ScopeIndent.IncorrectExact"