4 Rules removed#1061
Merged
klausi merged 2 commits intodrupal-graphql:8.x-4.xfrom Aug 10, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #1061 +/- ##
==========================================
Coverage 50.38% 50.38%
Complexity 683 683
==========================================
Files 118 118
Lines 1820 1820
==========================================
Hits 917 917
Misses 903 903
Continue to review full report at Codecov.
|
rthideaway
approved these changes
Aug 10, 2020
Contributor
rthideaway
left a comment
rthideaway
left a comment
There was a problem hiding this comment.
looks good! thanks!
found one just method name we could make a bit more clearer, let's resolve it, and then this PR can be merged
| * @covers \Drupal\graphql\Plugin\GraphQL\DataProducer\XML\XMLXpath::resolve | ||
| */ | ||
| public function testXMLXpath() { | ||
| public function testXmlxPath() { |
Contributor
There was a problem hiding this comment.
As words describing the method are basically test XML XPath, let's camelCase by the words, which for this case results into testXmlXpath
Contributor
Author
There was a problem hiding this comment.
Pushed new version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exclude name="Drupal.Files.EndFileNewline.NoneFound"
exclude name="Drupal.Files.EndFileNewline.TooMany"
exclude name="Drupal.Files.LineLength.TooLong"
exclude name="Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps"