Files excluded with Comment Rules#1073
Conversation
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #1073 +/- ##
==========================================
Coverage 50.51% 50.51%
Complexity 674 674
==========================================
Files 118 118
Lines 1827 1827
==========================================
Hits 923 923
Misses 904 904 Continue to review full report at Codecov.
|
rthideaway
left a comment
rthideaway
left a comment
There was a problem hiding this comment.
well, okay, but I think, someone should fix those comments instead as this list makes the whole phpcs config look very ugly and too long. I'll try to do it as far as I find some time. for now it's ok
|
@Dylan203 can you resolve the conflict please? then we can merge this as well |
rthideaway
left a comment
rthideaway
left a comment
There was a problem hiding this comment.
looks good, small improvement
| @@ -7,10 +7,305 @@ | |||
|
|
|||
| <rule ref="Drupal"> | |||
There was a problem hiding this comment.
as there is no rule anymore listeed here, let's fully remove this tag completely
| @@ -7,10 +7,305 @@ | |||
|
|
|||
| <rule ref="Drupal"> | |||
| <!-- TODO: those rules are disabled for now until we fix the coding standards for them. --> | |||
There was a problem hiding this comment.
this section is now empty, so the TODO comment should be moved/copied to the new exceptions we make below.
klausi
left a comment
klausi
left a comment
There was a problem hiding this comment.
Thanks, some questions.
We should also reference the DurpalPractice standard and check if we have any violations there. We could do this also in this pull request if we don't have a lot of fixes for that.
|
|
||
| <arg name="extensions" value="inc,install,module,php,profile,test,theme,yml"/> | ||
|
|
||
| <rule ref="Drupal"> |
There was a problem hiding this comment.
we need to keep this line, we want to reference the whole Drupal standard first.
| <exclude-pattern>tests/src/Kernel/GraphQLTestBase.php</exclude-pattern> | ||
| </rule> | ||
|
|
||
| <exclude-pattern>graphql.info.yml</exclude-pattern> |
There was a problem hiding this comment.
why do we exclude those yml files? Do we get any errors for them?
There was a problem hiding this comment.
If I remove phpcs is mad and gives out this error:
No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
There was a problem hiding this comment.
Ah I see, because phpcs somehow throws errors for them. That happens because you did not refernece a standard, so once you bring back the Drupal reference we should not see this.
There was a problem hiding this comment.
Jup build works now
|
Thank you! |
3 participants
exclude name="Drupal.Commenting.ClassComment.Missing"
exclude name="Drupal.Commenting.DocComment.MissingShort"
exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"
exclude name="Drupal.Commenting.FunctionComment.MissingReturnComment"