Phpstan first batch of fixes by Dylan203 · Pull Request #1075 · drupal-graphql/graphql

Dylan203 · 2020-08-31T12:01:57Z

No description provided.

klausi · 2020-08-31T12:06:29Z

   * @codeCoverageIgnore
   */
-  public function __construct(UrlGeneratorInterface $urlGenerator, Introspection $introspection, SchemaPluginManager $pluginManager) {
+  public final function __construct(UrlGeneratorInterface $urlGenerator, Introspection $introspection, SchemaPluginManager $pluginManager) {


in drupal we don't have final constructors. What is the error message from phstan that you get for this?

Unsafe usage of new static().
💡 Consider making the class or the constructor final.

ah yes, that is not a best practice in Drupal, so we should not fix that.
Use this exception:

# new static() is a best practice in Drupal, so we cannot fix that. - "#^Unsafe usage of new static\$\$\\.$#"

klausi · 2020-08-31T12:12:17Z

+	paths:
+		- ../../../graphql
+	excludes_analyse:
+		- ../../../graphql/src/Entity/Server.php #Class GraphQL\Executor\ExecutionResult not found.


you get this error because the onyx graphql vendor library might be missing locally?

I think you need the same setup as in travis CI: a drupal 8 checkout where this graphql module is in the modules folder + the composer dependencies installed.

Hmm ich schaus mir nochmal an.

Hab jetzt nochmal alles neu installiert, kriege immer noch diesen Error

Weiters kommt das immer ganz unten als Error auf:

Child process error (exit code 255): PHP Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in
phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125
Stack trace:
#0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime{closure}()
#1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php(18): spl_autoload_call()
#2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...')
#3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#5 [internal function]: spl_autoload_call()
#6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists()
#7 p in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php on line 18
Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in
phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125
Stack trace:
#0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime{closure}()
#1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php(18): spl_autoload_call()
#2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...')
#3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#5 [internal function]: spl_autoload_call()
#6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists()
#7 p in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php on line 18

Child process error (exit code 255): PHP Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php(18): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists() #7 p in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php on line 18 Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php(18): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists() #7 p in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/Resolver/Path.php on line 18 Child process error (exit code 255): PHP Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/Plugin/GraphQL/DataProducer/TypedData/PropertyPath.php(36): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider. in /home/dylan/Drupal8-Template/web/modules/graphql/src/Plugin/GraphQL/DataProducer/TypedData/PropertyPath.php on line 36 Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/Plugin/GraphQL/DataProducer/TypedData/PropertyPath.php(36): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider. in /home/dylan/Drupal8-Template/web/modules/graphql/src/Plugin/GraphQL/DataProducer/TypedData/PropertyPath.php on line 36 Child process error (exit code 255): PHP Fatal error: Declaration of Drupal\KernelTests\KernelTestBase::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in /home/dylan/Drupal8-Template/web/core/tests/Drupal/KernelTests/KernelTestBase.php on line 227 Fatal error: Declaration of Drupal\KernelTests\KernelTestBase::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void in /home/dylan/Drupal8-Template/web/core/tests/Drupal/KernelTests/KernelTestBase.php on line 227 Child process error (exit code 255): PHP Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/ResolverBuilder.php(22): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists() #7 in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/ResolverBuilder.php on line 22 Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\typed_data\DataFetcherTrait not found. in phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php:125 Stack trace: #0 [internal function]: PHPStan\Reflection\Runtime\RuntimeReflectionProvider->PHPStan\Reflection\Runtime\{closure}() #1 /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/ResolverBuilder.php(22): spl_autoload_call() #2 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(444): include('/home/dylan/Dru...') #3 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile() #4 [internal function]: Composer\Autoload\ClassLoader->loadClass() #5 [internal function]: spl_autoload_call() #6 phar:///home/dylan/Drupal8-Template/vendor/phpstan/phpstan/phpstan/src/Reflection/Runtime/RuntimeReflectionProvider.php(129): class_exists() #7 in /home/dylan/Drupal8-Template/web/modules/graphql/src/GraphQL/ResolverBuilder.php on line 22

you need to install the dependencies of graphql module, see https://github.com/drupal-graphql/graphql/blob/8.x-4.x/.travis.yml#L90

composer require webonyx/graphql-php:^0.13.1 drupal/typed_data:^1.0

klausi · 2020-08-31T13:24:25Z

+  # Install Phpstan to check for Drupal standards
+  - composer global require mglaman/phpstan-drupal ^0.12.3
+  - composer global require phpstan/phpstan-deprecation-rules ^0.12.2
+  - composer global require phpunit/phpunit


this line is not needed

klausi · 2020-08-31T13:25:29Z


+  # Install Phpstan to check for Drupal standards
+  - composer global require mglaman/phpstan-drupal ^0.12.3
+  - composer global require phpstan/phpstan-deprecation-rules ^0.12.2


those 2 lines can be summarized into 1. We should also run it the same way as above for webonyx/graphql-php

klausi · 2020-08-31T13:32:28Z

    fi
+
+  # Run Phpstan
+  - cd $DRUPAL_BUILD_DIR && ../vendor/bin/phpstan analyse -c /modules/graphql/phpstan.neon


we need to run phpstan in the graphql module directory, like we do with phpcs above

klausi

Oh wow nice, thanks for finishing this up Rado!!!!

Not that of a big change and almost everything looks good to me. 2 minor comments for the config file, but then we can merge this.

I saw that we forgot to add the fileExtensions config https://phpstan.org/config-reference#analysed-files . We don't have much code in module files, so should not be a big difference. We can do this here or in a follow-up.

klausi · 2020-09-10T07:23:34Z

+	level: 1
+	customRulesetUsed: true
+	paths:
+		- ../graphql


can we just use "."?

actually I was looking at this as well :D wanted to fix it and forgot about it, will adjust it

klausi · 2020-09-10T07:24:02Z

+	ignoreErrors:
+		# @todo Ignore phpstan-drupal extension's rules for now, activate later.
+		- '#\Drupal calls should be avoided in classes, use dependency injection instead#'
+    	# We have a hacked Symfony 4 event component (instead of 3) because of


Copy/paste error for this comment?

Dylan203 added 2 commits August 31, 2020 14:00

Phpstan

eb51238

phpcs errors fixed

9aaceba

klausi reviewed Aug 31, 2020

View reviewed changes

Travis Config added. Baseline could not be generated

17ab6fc

klausi requested changes Aug 31, 2020

View reviewed changes

Dylan203 and others added 24 commits August 31, 2020 15:56

Travis config changed

757da5c

Travis config changed

f945ba2

Travis Build error fixes

7f56db7

Another fix

f656b17

reverted fix

3d78e03

Merge branch '8.x-4.x' into fix/phpstan-iteration-1

417c5c2

Fix running phpstan.

78894eb

Remove all final constructors.

699c84d

Fix vendor paths.

5185016

Install phpstan into graphql module.

b015502

Simplify path to binary.

2adae32

Exclude vendor folder.

66122e6

Revert back.

0db5efd

Fix path.

9380f6b

Debug.

02f1240

Remove config file.

11641f3

Debug.

0af46cc

Debug.

261a756

Fix paths again.

1b15f2c

Fix paths again.

10628b7

Debug.

0ab59a6

Fix paths again.

9f69d3c

Debug.

55a5521

Remove symlink.

8fc331f

rthideaway added 22 commits September 9, 2020 14:14

Debug.

c2c67f0

Fix symlink.

5a370c4

Adapt conf.

3a2414f

Copy module so phpstan can find drupal.

58a1926

Remove drupal parameter.

69bb71d

Revert change.

36d515c

Fix using deprecated event.

b741fb9

Fix cache key reports.

234adc5

Fix optional arguments.

7b3067f

Remove unused stub function.

defbc21

One more optional argument fix.

ced2dcc

Fix invalid typehint inRouteLoad.

da2abee

Fix invalid typehint EntityReference.

8089cbe

Adapt neon.

58e109b

Revert paths.

830bae7

CS fix.

95c9c8f

Suppress event dispatcher errors.

bca5ec0

Fix optional arguments.

be9f014

Remove redundant ignore error.

18b11fa

Fix RouteLoad typehint.

8d5a5cb

Revert fix RouteLoad typehint.

a7b5240

Require redirect module.

b5dc89d

rthideaway requested a review from klausi September 9, 2020 20:50

rthideaway self-assigned this Sep 9, 2020

klausi approved these changes Sep 10, 2020

View reviewed changes

rthideaway added 2 commits September 10, 2020 09:48

Simplify path.

54db140

Remove copy paste leftover.

b8c0dd7

rthideaway merged commit dad9d59 into drupal-graphql:8.x-4.x Sep 10, 2020

Conversation

Dylan203 commented Aug 31, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klausi Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klausi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

klausi Aug 31, 2020 •

edited

Loading