Skip to content

Conversation

@klausi
Copy link
Contributor

@klausi klausi commented Nov 17, 2020

When you want to combine violations of 2 response classes then a helper would be convenient.

Copy link
Contributor

@rthideaway rthideaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks!

@klausi
Copy link
Contributor Author

klausi commented Nov 18, 2020

This is a small API break since we are changing an interface here, but I think this is not in wide use and most people inherit from the Response base class anyway.

@klausi klausi merged commit 794ce3c into drupal-graphql:8.x-4.x Nov 18, 2020
@klausi klausi deleted the merge-violations branch November 18, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants