test(EntityDefinition): Add test case for base field and configured field filter#1140
Merged
klausi merged 8 commits intodrupal-graphql:8.x-4.xfrom Jan 12, 2021
Merged
Conversation
… into rthideaway-fix/field-types
rthideaway
approved these changes
Jan 11, 2021
| $expectedResult = $this->fullDefinitionResult; | ||
| // Remove the one configured field that should not be in the list of base | ||
| // fields. | ||
| unset($expectedResult['entityDefinition']['fields'][18]); |
Contributor
There was a problem hiding this comment.
maybe we could split the list of expected fields result into two variables - base fields result and configurable fields result. then use array_merge if we need to compare both of them:
protected function getEntityDefinitionResult(string $type, array $result) {
return [
'entityDefinition' =>
[
'label' => $type,
'fields' => $result,
]
];
}
$fullDefinitionResult = $this->getEntityDefinitionResult('Content', array_merge($this->baseFieldResult, $this->configFieldResult));
or if need a specific one:
$baseFieldDefinitionResult = $this->getEntityDefinitionResult('Content', $this->baseFieldResult);
but fine for me this way as well
Contributor
Author
There was a problem hiding this comment.
There is just one configured field, so I would leave it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #991 , adding 2 test cases.