feat(DataProducer): make sure Weight returns int #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This happens because we sometimes use float as weight for custom fields that need to be between 2 other predefined fields. That is only half-supported by Drupal core anyway, so I think we can use this as is without test case. |
klausi
pushed a commit
to klausi/graphql
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit conversion fo float to int generates warning in PHP 8.1
e.g.:
Deprecated function: Implicit conversion from float 2.5 to int loses precision in Drupal\graphql\Plugin\GraphQL\DataProducer\EntityDefinition\Fields\Weight->resolve() (line 52 of /var/www/html/backend/web/modules/contrib/graphql/src/Plugin/GraphQL/DataProducer/EntityDefinition/Fields/Weight.php)