Skip to content

fix(SdlSchemaPluginBase): Allowing empty extension document when you …#846

Merged
fubhy merged 3 commits intodrupal-graphql:8.x-4.xfrom
LennardWesterveld:bugfix/allow-empty-extension-document
Jul 13, 2019
Merged

fix(SdlSchemaPluginBase): Allowing empty extension document when you …#846
fubhy merged 3 commits intodrupal-graphql:8.x-4.xfrom
LennardWesterveld:bugfix/allow-empty-extension-document

Conversation

@LennardWesterveld
Copy link
Copy Markdown
Contributor

…only want to declare interfaces for instance.

…only want to declare interfaces for instance.
Comment thread src/Plugin/GraphQL/Schema/SdlSchemaPluginBase.php Outdated
Comment thread src/Plugin/GraphQL/Schema/SdlSchemaPluginBase.php Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2019

Codecov Report

Merging #846 into 8.x-4.x will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-4.x     #846      +/-   ##
=============================================
- Coverage      66.87%   66.66%   -0.21%     
- Complexity       548      550       +2     
=============================================
  Files             91       91              
  Lines           1274     1278       +4     
=============================================
  Hits             852      852              
- Misses           422      426       +4
Impacted Files Coverage Δ Complexity Δ
src/Plugin/GraphQL/Schema/SdlSchemaPluginBase.php 43.39% <0%> (-3.55%) 24 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251dc40...8b56826. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2019

Codecov Report

Merging #846 into 8.x-4.x will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-4.x     #846      +/-   ##
=============================================
- Coverage      66.87%   66.77%   -0.11%     
- Complexity       548      550       +2     
=============================================
  Files             91       91              
  Lines           1274     1276       +2     
=============================================
  Hits             852      852              
- Misses           422      424       +2
Impacted Files Coverage Δ Complexity Δ
src/Plugin/GraphQL/Schema/SdlSchemaPluginBase.php 45.09% <0%> (-1.85%) 24 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251dc40...a71e73b. Read the comment docs.

@fubhy fubhy merged commit 6c6d8f3 into drupal-graphql:8.x-4.x Jul 13, 2019
@LennardWesterveld LennardWesterveld deleted the bugfix/allow-empty-extension-document branch July 13, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants