fix(travis): Allow failures instead of completely disabling PHP 7.3 testing#875
Merged
klausi merged 5 commits intodrupal-graphql:8.x-4.xfrom Aug 6, 2019
Merged
Conversation
…cannot reproduce the error
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #875 +/- ##
==========================================
Coverage 66.92% 66.92%
Complexity 553 553
==========================================
Files 91 91
Lines 1273 1273
==========================================
Hits 852 852
Misses 421 421Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, #874 should have been actually this.
That way we also restore the 2 different PHP 7.2 runs, one for code coverage.
Let's see if this passes on Travis.