Add dimensions for images#938
Merged
fubhy merged 1 commit intodrupal-graphql:8.x-4.xfrom Nov 4, 2019
Merged
Conversation
By default Drupal doesn't provide dimensions for files entities. This information is saved at the field level. In order to have dimensions when we request derivatives, we need to get those values to fill the height and width for a given image like this we will get the calculated dimensions for the style requested.
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #938 +/- ##
============================================
- Coverage 61.91% 61.81% -0.1%
- Complexity 675 678 +3
============================================
Files 95 95
Lines 1402 1409 +7
============================================
+ Hits 868 871 +3
- Misses 534 538 +4
Continue to review full report at Codecov.
|
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default Drupal doesn't provide dimensions for files entities. This information is saved at the field level. In order to have dimensions when we request derivatives, we need to get those values to fill the height and width for a given image like this we will get the calculated dimensions for the style requested.