Skip to content

Add dimensions for images#938

Merged
fubhy merged 1 commit intodrupal-graphql:8.x-4.xfrom
yvmarques:patch-2
Nov 4, 2019
Merged

Add dimensions for images#938
fubhy merged 1 commit intodrupal-graphql:8.x-4.xfrom
yvmarques:patch-2

Conversation

@yvmarques
Copy link
Copy Markdown
Contributor

By default Drupal doesn't provide dimensions for files entities. This information is saved at the field level. In order to have dimensions when we request derivatives, we need to get those values to fill the height and width for a given image like this we will get the calculated dimensions for the style requested.

By default Drupal doesn't provide dimensions for files entities. This information is saved at the field level. In order to have dimensions when we request derivatives, we need to get those values to fill the height and width for a given image like this we will get the calculated dimensions for the style requested.
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2019

Codecov Report

Merging #938 into 8.x-4.x will decrease coverage by 0.09%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             8.x-4.x     #938     +/-   ##
============================================
- Coverage      61.91%   61.81%   -0.1%     
- Complexity       675      678      +3     
============================================
  Files             95       95             
  Lines           1402     1409      +7     
============================================
+ Hits             868      871      +3     
- Misses           534      538      +4
Impacted Files Coverage Δ Complexity Δ
...taProducer/Entity/Fields/Image/ImageDerivative.php 76.19% <55.55%> (-16.67%) 7 <0> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc7096...f3ac8fc. Read the comment docs.

@fubhy fubhy merged commit b0055eb into drupal-graphql:8.x-4.x Nov 4, 2019
@fubhy
Copy link
Copy Markdown
Contributor

fubhy commented Nov 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants