Fix problems with entity form display context for entity definition data producers.#998
Merged
klausi merged 5 commits intodrupal-graphql:8.x-4.xfrom Dec 14, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #998 +/- ##
==========================================
Coverage ? 52.82%
Complexity ? 635
==========================================
Files ? 115
Lines ? 1626
Branches ? 0
==========================================
Hits ? 859
Misses ? 767
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
|
I think this makes sense, we should add some test cases to make sure this works. |
Contributor
|
I will merge this now to credit @rthideaway and the follow up in #1132 |
klausi
pushed a commit
to klausi/graphql
that referenced
this pull request
Sep 21, 2023
… for entity definition data producers. (drupal-graphql#998)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently we have found that entity form display context is incorrectly set in
entity_definition_fieldsdata producer. Drupal contains entity form displays per bundle, so it makes set this context only when bundle context is included. Fixed that.Then the context was incorrectly used in couple of field data producers, namely in
entity_definition_field_hidden,entity_definition_field_settingsandentity_definition_field_weight. Fixed that as well.