Issue #2689911 by andypost: Use a lazy builder in the AddToCartFormatter#358
Closed
andypost wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom
Closed
Issue #2689911 by andypost: Use a lazy builder in the AddToCartFormatter#358andypost wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom
andypost wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom
Conversation
Author
andypost
force-pushed
the
2689911-lazy-cart-formatter
branch
from
4bb8dd1 to
5551fe6
Compare
Contributor
|
This looks good. However, commerce_cart shouldn't be aware of commerce_product, only the opposite. Since the code in CartLazyBuilders is product specific, it makes more sense for it to live in commerce_product as ProductLazyBuilders (this also allows you to remove the $product_type_id parameter, which is misnamed since it actually gives you the entity type id -> 'commerce_product') |
Author
|
Thanx for pointer, I got missed the point of mapping, will update latter |
Author
|
Looks ready, should I add a patch to d.o issue or how to proceed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's it