Issue #2807559: Add owner filter to order/cart overview#553
Open
cornifex wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
Open
Issue #2807559: Add owner filter to order/cart overview#553cornifex wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
cornifex wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
Conversation
bojanz
requested changes
Nov 16, 2016
| exposed: true | ||
| expose: | ||
| operator_id: combine_op | ||
| label: Owner |
Contributor
There was a problem hiding this comment.
This should be "Customer" instead of "Owner"
| destination: true | ||
| entity_type: commerce_order | ||
| plugin_id: entity_operations | ||
| name: |
Contributor
There was a problem hiding this comment.
Why did you add this? We already have a Customer column that shows the user name.
Contributor
Author
There was a problem hiding this comment.
Had to add it to use in the combined filter, otherwise it would only search by UID
Contributor
There was a problem hiding this comment.
@bojanz we'll only be able to search by contact mail without it. The combined filters filter requires fields in the "Fields" section.
cornifex
force-pushed
the
2807559-filter-by-owner
branch
2 times, most recently
from
fa2c522 to
b4009d9
Compare
Contributor
|
This needs codestyle fix. Newline. |
mglaman
force-pushed
the
2807559-filter-by-owner
branch
from
d182fe7 to
84a09eb
Compare
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
68e6e5f to
ac287b7
Compare
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c to
b8a7444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.