Issue #2869333 by agoradesign: Move store context from PriceDefaultFo…#713
Merged
bojanz merged 1 commit intodrupalcommerce:8.x-2.xfrom Apr 20, 2017
Merged
Conversation
…rmatter to PriceCalculatedFormatter
mglaman
previously requested changes
Apr 13, 2017
| parent::__construct($plugin_id, $plugin_definition, $field_definition, $settings, $label, $view_mode, $third_party_settings, $entity_type_manager, $number_formatter_factory); | ||
|
|
||
| $this->chainPriceResolver = $chain_price_resolver; | ||
| $this->storeContext = $store_context; |
Contributor
There was a problem hiding this comment.
This isn't being injected anymore. The constructor lists it but you did not override the parent create method.
Contributor
Author
There was a problem hiding this comment.
The parent create() method is already overridden anyway (and of course already containing the store context)
bradjones1
pushed a commit
to bradjones1/commerce
that referenced
this pull request
May 4, 2017
…rmatter to PriceCalculatedFormatter (drupalcommerce#713)
nikathone
pushed a commit
to nikathone/commerce
that referenced
this pull request
Feb 2, 2018
…rmatter to PriceCalculatedFormatter (drupalcommerce#713)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rmatter to PriceCalculatedFormatter