Multiple add to cart forms with different variation types throws exception#758
Merged
bojanz merged 1 commit intodrupalcommerce:8.x-2.xfrom Jul 12, 2017
Conversation
mglaman
commented
Jul 10, 2017
| } | ||
|
|
||
| return $current_variation; | ||
| $form_state->setValueForElement($element['variation'], $current_variation->id()); |
Contributor
Author
There was a problem hiding this comment.
This does not persist. It only sets the value during the validation cycle, which causes test fails.
I think commerce_product_variation_select element is what we need. Handle loadEnabled, filtering access. Displaying attributes and resolving final variant ID. So we do not need to attempt to piece the attributes to a variation within the widget.
mglaman
force-pushed
the
2893182-multiple-add-to-cart-oddball-attributes
branch
from
567f061 to
9b3aa9e
Compare
…fferent variation types throws exception
mglaman
force-pushed
the
2893182-multiple-add-to-cart-oddball-attributes
branch
from
9b3aa9e to
c3dc40b
Compare
nikathone
pushed a commit
to nikathone/commerce
that referenced
this pull request
Feb 2, 2018
…fferent variation types throws exception (drupalcommerce#758)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.