Skip to content

Apply Text area (mainly WYSIWYG editor) style updates#68

Open
zolhorvath wants to merge 8 commits into
drupalux:masterfrom
zolhorvath:task/issue-21
Open

Apply Text area (mainly WYSIWYG editor) style updates#68
zolhorvath wants to merge 8 commits into
drupalux:masterfrom
zolhorvath:task/issue-21

Conversation

@zolhorvath
Copy link
Copy Markdown
Contributor

@zolhorvath zolhorvath commented Nov 29, 2018

Issue

This PR fix #21.

Screenshots before/after (now Chrome on OSX only)

01--textarea--mac-os-x--chrome
02--textarea-errors--mac-os-x--chrome

Todo

Testing instructions

  • Add https://github.com/zolhorvath/seven-refresh/ as drupal-profile (sevenrefresh) to a Drupal project.
  • Remove core/themes/seven
  • Make sure that this theme is installed to themes/custom/seven
  • Symlink core/misc to themes/custom/misc
  • Run yarn && yarn build:css in the theme's root
  • Install a Drupal with profile sevenrefresh. This will enable additional field types such as telephone or date_range and enable styleguide drupal module as well

After that Drupal is installed, Styleguide will be the front page and you'll have the test form at /contact/textarea.

@zolhorvath zolhorvath changed the title WIP: Apply Text area (mainly WYSIWYG editor) style updates Apply Text area (mainly WYSIWYG editor) style updates Dec 13, 2018
@zolhorvath
Copy link
Copy Markdown
Contributor Author

@zolhorvath zolhorvath requested review from ckrina and lauriii December 13, 2018 12:44
Comment thread claro.theme
Comment thread templates/filter/filter-guidelines.html.twig
@zolhorvath
Copy link
Copy Markdown
Contributor Author

Disabled editor has to be fixed, see #74

Copy link
Copy Markdown
Contributor

@ckrina ckrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that when you expand the summary for a text area, the summary itself has the correct font size but not the textarea with the WYSIWYG.
ckeditor

@zolhorvath
Copy link
Copy Markdown
Contributor Author

zolhorvath commented Jan 3, 2019

@ckrina I added an improvement for the case when Claro is the front end theme. (I think it's a very limited use case, but maybe it's worth to do so.)

However, as I see, you're using Bartik as a front end theme. Bartik provides CKEditor stylesheets as well, an in that case, CKEditor inputs are using those to provide a visual feedback for editors about how the text looks on front end theme, see the API doc about this feature (at API features / CKEditor iframe CSS / Front-end theme CSS).

@ckrina
Copy link
Copy Markdown
Contributor

ckrina commented Jan 3, 2019

Thanks @zolhorvath ! I just changed the frontend theme to Claro too, but now it takes the styles from the core ckeditor modules and ends up using Arial instead of the system fonts, and it looks really strange having a text area with one font and the other with another one. Is there any way to change this?

arial

@zolhorvath
Copy link
Copy Markdown
Contributor Author

@ckrina did you refreshed the theme?

@ckrina
Copy link
Copy Markdown
Contributor

ckrina commented Jan 3, 2019

You're right, sorry! I forgot the yarn command. The everything good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text area style updates

3 participants