Skip to content

Lightning 8.x 4.x#165

Merged
sylus merged 6 commits into
8.x-2.xfrom
lightning-8.x-4.x
May 20, 2019
Merged

Lightning 8.x 4.x#165
sylus merged 6 commits into
8.x-2.xfrom
lightning-8.x-4.x

Conversation

@spotzero
Copy link
Copy Markdown
Contributor

This PR updates to Lighting 4.0 with Drupal 8.7.1 and cleans up the patches.

@spotzero spotzero requested review from nathanv, sylus and zachomedia May 17, 2019 17:52
@spotzero
Copy link
Copy Markdown
Contributor Author

A note about the patches I modified:

  • The first was merged into 8.7 (yah!)
  • The second I updated with the newest version.
  • The third has been closed as "Cannot reproduce" and the patch for 8.7 wasn't created correctly so it doesn't apply. The patch is in https://www.drupal.org/node/2914233. The comment from the core team was actually "won't fix" and they advised that the issue should be fixed in the templates having problems directly. I've removed that patch, but I haven't done sufficient testing on specifically that issue to see if what, if anything, remains to be fix.

@spotzero
Copy link
Copy Markdown
Contributor Author

There is also some discussion about this here: https://www.drupal.org/project/wxt/issues/3049222

@spotzero
Copy link
Copy Markdown
Contributor Author

spotzero commented May 17, 2019

Testing https://www.drupal.org/node/2914233 shows that it does not work. I'm looking into the suggested fix.

@spotzero
Copy link
Copy Markdown
Contributor Author

2914233 should actually be fixed in panelizer. I've contributed here: https://www.drupal.org/project/panelizer/issues/2750491#comment-13111032

I'll add the patch into the composer file on this branch.

@spotzero
Copy link
Copy Markdown
Contributor Author

Alright, the preview panelizer patch is in now.

@sylus sylus merged commit cd7ed96 into 8.x-2.x May 20, 2019
@sylus sylus deleted the lightning-8.x-4.x branch May 20, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants