feat: emit empty lines without trailing whitespace#9
Conversation
|
@wolfgangwalther Feel free to review it :) |
4f28558 to
230f8f8
Compare
|
I'd like to try this when #8 is merged and this branch rebased on it. That's easier with the override I already have. |
230f8f8 to
dd81e6a
Compare
|
Here you go, let me know how it goes, after that I think this project will deserve a tag. |
|
I get a test failure on this branch when building: |
| }), | ||
| ) | ||
| .chain(std::iter::once("```".to_string())) | ||
| .map(|l| format!("{:indent$}{}", "", l, indent = block.indent)) |
There was a problem hiding this comment.
After disabling the checkPhase, I ran it, but this doesn't work for me, yet.
Should the trimming happen after the indent step here? I think it should!
There was a problem hiding this comment.
Or put differently: Only indent, when the line is non-empty?
There was a problem hiding this comment.
I updated it, it would be super great if you could give me some feedback to get this done.
7a27d11 to
6f2e4d2
Compare
wolfgangwalther
left a comment
There was a problem hiding this comment.
Yes, this works!
|
Waiting for a last confirmation from you and merging this. |
|
|
1d2585b to
0011265
Compare
|
Excellent ! |
fix #7 Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
0011265 to
57cd462
Compare
This PR
fix #7