Remove deprecated string features.

Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5

Author: lrhn

pkg/fixnum/lib/src/int32.dart

@@ -38,12 +38,12 @@ class int32 implements intx {
   static int32 TWO = const int32._internal(2);
 
   // Hex digit char codes
-  static const int _CC_0 = 48; // '0'.charCodeAt(0)
-  static const int _CC_9 = 57; // '9'.charCodeAt(0)
-  static const int _CC_a = 97; // 'a'.charCodeAt(0)
-  static const int _CC_z = 122; // 'z'.charCodeAt(0)
-  static const int _CC_A = 65; // 'A'.charCodeAt(0)
-  static const int _CC_Z = 90; // 'Z'.charCodeAt(0)
+  static const int _CC_0 = 48; // '0'.codeUnitAt(0)
+  static const int _CC_9 = 57; // '9'.codeUnitAt(0)
+  static const int _CC_a = 97; // 'a'.codeUnitAt(0)
+  static const int _CC_z = 122; // 'z'.codeUnitAt(0)
+  static const int _CC_A = 65; // 'A'.codeUnitAt(0)
+  static const int _CC_Z = 90; // 'Z'.codeUnitAt(0)
 
   static int _decodeHex(int c) {
     if (c >= _CC_0 && c <= _CC_9) {
@@ -68,10 +68,10 @@ class int32 implements intx {
     }
     int32 x = ZERO;
     for (int i = 0; i < s.length; i++) {
-      int c = s.charCodeAt(i);
+      int c = s.codeUnitAt(i);
       int digit = _decodeHex(c);
       if (digit < 0 || digit >= radix) {
-        throw new Exception("Non-radix char code: $c");
+        throw new Exception("Non-radix code unit: $c");
       }
       x = (x * radix) + digit;
     }

pkg/fixnum/lib/src/int64.dart

@@ -130,7 +130,7 @@ class int64 implements intx {
       i++;
     }
     for (; i < s.length; i++) {
-      int c = s.charCodeAt(i);
+      int c = s.codeUnitAt(i);
       int digit = int32._decodeHex(c);
       if (digit < 0 || digit >= radix) {
         throw new Exception("Non-radix char code: $c");

pkg/http/lib/src/multipart_request.dart

@@ -98,7 +98,7 @@ class MultipartRequest extends BaseRequest {
 
     void writeAscii(String string) {
       assert(isPlainAscii(string));
-      controller.add(string.charCodes);
+      controller.add(string.codeUnits);
     }
 
     writeUtf8(String string) => controller.add(encodeUtf8(string));

pkg/http/lib/src/utils.dart

@@ -111,7 +111,7 @@ String decodeString(List<int> bytes, Encoding encoding) {
 /// Converts [string] into a byte array according to [encoding].
 List<int> encodeString(String string, Encoding encoding) {
   // TODO(nweiz): implement this once issue 6284 is fixed.
-  return string.charCodes;
+  return string.codeUnits;
 }
 
 /// A regular expression that matches strings that are composed entirely of

pkg/http/test/client_test.dart

@@ -41,7 +41,7 @@ void main() {
         'body': '{"hello": "world"}'
       }))));
 
-      request.sink.add('{"hello": "world"}'.charCodes);
+      request.sink.add('{"hello": "world"}'.codeUnits);
       request.sink.close();
     }), completes);
   });
@@ -56,7 +56,7 @@ void main() {
 
       expect(client.send(request), throwsSocketIOException);
 
-      request.sink.add('{"hello": "world"}'.charCodes);
+      request.sink.add('{"hello": "world"}'.codeUnits);
       request.sink.close();
     }), completes);
   });

pkg/http/test/mock_client_test.dart

@@ -37,7 +37,7 @@ void main() {
       return bodyStream.bytesToString().then((bodyString) {
         var controller = new StreamController<List<int>>();
         async.then((_) {
-          controller.add('Request body was "$bodyString"'.charCodes);
+          controller.add('Request body was "$bodyString"'.codeUnits);
           controller.close();
         });
 

pkg/intl/lib/number_format.dart

@@ -169,7 +169,7 @@ class NumberFormat {
       paddingDigits.add(symbols.ZERO_DIGIT);
       intValue = intValue ~/ 10;
     }
-    var integerDigits = "${intValue}${paddingDigits}".charCodes;
+    var integerDigits = "${intValue}${paddingDigits}".codeUnits;
     var digitLength = integerDigits.length;
 
     if (_hasPrintableIntegerPart(intValue)) {
@@ -191,7 +191,7 @@ class NumberFormat {
    * Format the part after the decimal place in a fixed point number.
    */
   void _formatFractionPart(String fractionPart) {
-    var fractionCodes = fractionPart.charCodes;
+    var fractionCodes = fractionPart.codeUnits;
     var fractionLength = fractionPart.length;
     while (fractionPart[fractionLength - 1] == '0' &&
            fractionLength > _minimumFractionDigits + 1) {
@@ -237,7 +237,7 @@ class NumberFormat {
     for (var i = 0; i < numberOfDigits - basic.length; i++) {
       _add(symbols.ZERO_DIGIT);
     }
-    for (var x in basic.charCodes) {
+    for (var x in basic.codeUnits) {
       _addDigit(x);
     }
   }

pkg/serialization/test/polyfill_identity_map_test.dart

@@ -40,9 +40,9 @@ main() {
   test('uniquing primitives', () {
     var map = new IdentityMap();
     var one = 'one';
-    var two = new String.fromCharCodes(one.charCodes);
+    var two = new String.fromCharCodes(one.codeUnits);
     map[one] = 1;
     expect(map[two], 1);
     expect(map[one], 1);
   });
-}
+}

pkg/serialization/test/serialization_test.dart

@@ -154,7 +154,7 @@ main() {
     var l = keysAndValues(list);
     var s = keysAndValues(set);
 
-    m.forEach((key, value) {expect(key.charCodes[0], value + 96);});
+    m.forEach((key, value) {expect(key.codeUnits[0], value + 96);});
     l.forEach((key, value) {expect(key + 1, value);});
     var index = 0;
     var seen = new Set();

pkg/webdriver/lib/src/base64decoder.dart

@@ -11,7 +11,7 @@ part of webdriver;
 class Base64Decoder {
 
   static int getVal(String s, pos) {
-    int code = s.charCodeAt(pos);
+    int code = s.codeUnitAt(pos);
     if (code >= 65 && code < (65+26)) { // 'A'..'Z'
       return code - 65;
     } else if (code >= 97 && code < (97+26)) { // 'a'..'z'