Skip to content

Commit dbd1b2f

Browse files
rmacnak-googlecommit-bot@chromium.org
authored andcommitted
[test] Reload harness now reloads from, e.g. the URI of a snapshot or kernel file instead of the URI of the source from which it was derived.
Change-Id: I6652c6594532e911e68eb29904a9e95927910ee0 Reviewed-on: https://dart-review.googlesource.com/64665 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
1 parent c262819 commit dbd1b2f

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

runtime/tests/vm/vm.status

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,10 @@ cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
358358
dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors
359359

360360
[ $hot_reload || $hot_reload_rollback ]
361-
dart/appjit_determinism_test: Skip # Reload affects determinisim
362-
dart/script_determinism_test: Skip # We can shutdown an isolate before it reloads.
363-
dart/slow_path_shared_stub_test: Skip # Too slow with --slow-path-triggers-gc flag and not relevant outside precompiled.
361+
dart/appjit_cha_deopt_test: SkipByDesign # Cannot reload with URI pointing to app snapshot.
362+
dart/appjit_determinism_test: SkipByDesign # Reload affects determinisim
363+
dart/script_determinism_test: SkipbyDesign # Cannot reload with URI pointing to script snapshot.
364+
dart/slow_path_shared_stub_test: SkipSlow # Too slow with --slow-path-triggers-gc flag and not relevant outside precompiled.
364365
dart/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads.
365366
dart/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads.
366-
dart/stack_overflow_shared_test: Skip # Too slow with --slow-path-triggers-gc flag and not relevant outside precompiled.
367+
dart/stack_overflow_shared_test: SkipSlow # Too slow with --slow-path-triggers-gc flag and not relevant outside precompiled.

samples/samples.status

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,5 @@ build_dart_simple/*: Skip
4141
sample_extension/*: Skip
4242

4343
[ $hot_reload || $hot_reload_rollback ]
44-
sample_extension/test/sample_extension_script_snapshot_test: SkipByDesign # This test makes a script snapshot, which implies not exercising Dart code.
44+
sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign # Cannot reload with URI pointing to app snapshot.
45+
sample_extension/test/sample_extension_script_snapshot_test: SkipByDesign # Cannot reload with URI pointing to script snapshot.

0 commit comments

Comments
 (0)