docs: use ${GIT_HOME_PUBLIC} path var across plugin docs and skills#330
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces hardcoded home directory paths (~/git/) with the environment variable ${GIT_HOME_PUBLIC} across multiple markdown documentation and skill files to support dynamic workspace paths. The review feedback correctly identifies two path-related issues: first, CLAUDE.md is a repository-specific file and its path should point to ${GIT_HOME_PUBLIC}/<repo>/main/CLAUDE.md instead of the root of the public git home directory; second, the repository glob pattern should be updated to match the flat directory structure by removing the <owner> placeholder.
Sweep hardcoded `~/git/...` references in plugin skills, rules, and READMEs
to use the ${GIT_HOME_PUBLIC} workspace variable introduced in nix-home v1.23.0.
Skills like /sync-main, /refresh-repo, /troubleshoot-worktree, /orchestrate-infra
etc. now show path templates that model the public/private workspace split
modeled by every recent doc change.
Files (10):
- .claude/rules/worktree-conventions.md
- codeql-resolver/README.md
- git-standards/skills/git-workflow-standards/SKILL.md
- git-workflows/skills/sync-main/SKILL.md
- git-workflows/skills/troubleshoot-worktree/SKILL.md
- github-workflows/skills/rebase-pr/SKILL.md
- github-workflows/skills/refresh-repo/SKILL.md
- infra-orchestration/skills/orchestrate-infra/SKILL.md
- infra-orchestration/skills/sync-inventory/SKILL.md
- infra-orchestration/skills/test-e2e/SKILL.md
Assisted-by: Claude <noreply@anthropic.com>
JacobPEvans
force-pushed
the
chore/git-home-path-vars
branch
from
9ee844a to
f341b5c
Compare
JacobPEvans
added a commit
that referenced
this pull request
May 25, 2026
PR #330 swapped hardcoded `~/git/...` for `${GIT_HOME_PUBLIC}/<repo>/...`. Reviewer follow-up: skill docs should not bake a workspace path convention into prose either — describe what to do, not where files live. Changes (10 files): - .claude/rules/worktree-conventions.md: convention table now shows relative paths (`<repo>/main/`, `<repo>/{branch-name}/`). Operational "switch to main and sync" line drops the `cd`, says "From the main worktree, sync". - git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use `../` from the main worktree. - git-workflows/skills/sync-main: "find and sync main" describes the worktree role; drops `cd`. - git-workflows/skills/troubleshoot-worktree: `git worktree add ../<branch>` (relative). - github-workflows/skills/rebase-pr: "from the main worktree" framing. - github-workflows/skills/refresh-repo: drops the `${GIT_HOME}/CLAUDE.md` citation (just "per the workspace convention"); drops the `${GIT_HOME_PUBLIC}/<repo>/<default>/` path-resolution rule in favor of `git worktree list --porcelain` matching on `branch refs/heads/<default>`; --sweep glob description loosened. - infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob. - infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only, not paths. - infra-orchestration/test-e2e: same. - codeql-resolver/README.md: examples annotate the worktree, drop `cd`. The `${GIT_HOME}` / `${GIT_HOME_PUBLIC}` nix-home sessionVariables still exist for workspace tooling — this PR just stops mentioning them in plugin docs where they're not load-bearing. Assisted-by: Claude <noreply@anthropic.com>
JacobPEvans
added a commit
that referenced
this pull request
May 25, 2026
PR #330 swapped hardcoded `~/git/...` for `${GIT_HOME_PUBLIC}/<repo>/...`. Reviewer follow-up: skill docs should not bake a workspace path convention into prose either — describe what to do, not where files live. Changes (10 files): - .claude/rules/worktree-conventions.md: convention table now shows relative paths (`<repo>/main/`, `<repo>/{branch-name}/`). Operational "switch to main and sync" line drops the `cd`, says "From the main worktree, sync". - git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use `../` from the main worktree. - git-workflows/skills/sync-main: "find and sync main" describes the worktree role; drops `cd`. - git-workflows/skills/troubleshoot-worktree: `git worktree add ../<branch>` (relative). - github-workflows/skills/rebase-pr: "from the main worktree" framing. - github-workflows/skills/refresh-repo: drops the `${GIT_HOME}/CLAUDE.md` citation (just "per the workspace convention"); drops the `${GIT_HOME_PUBLIC}/<repo>/<default>/` path-resolution rule in favor of `git worktree list --porcelain` matching on `branch refs/heads/<default>`; --sweep glob description loosened. - infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob. - infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only, not paths. - infra-orchestration/test-e2e: same. - codeql-resolver/README.md: examples annotate the worktree, drop `cd`. The `${GIT_HOME}` / `${GIT_HOME_PUBLIC}` nix-home sessionVariables still exist for workspace tooling — this PR just stops mentioning them in plugin docs where they're not load-bearing. Assisted-by: Claude <noreply@anthropic.com>
JacobPEvans
added a commit
that referenced
this pull request
May 25, 2026
PR #330 swapped hardcoded `~/git/...` for `${GIT_HOME_PUBLIC}/<repo>/...`. Reviewer follow-up: skill docs should not bake a workspace path convention into prose either — describe what to do, not where files live. Changes (10 files): - .claude/rules/worktree-conventions.md: convention table now shows relative paths (`<repo>/main/`, `<repo>/{branch-name}/`). Operational "switch to main and sync" line drops the `cd`, says "From the main worktree, sync". - git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use `../` from the main worktree. - git-workflows/skills/sync-main: "find and sync main" describes the worktree role; drops `cd`. - git-workflows/skills/troubleshoot-worktree: `git worktree add ../<branch>` (relative). - github-workflows/skills/rebase-pr: "from the main worktree" framing. - github-workflows/skills/refresh-repo: drops the `${GIT_HOME}/CLAUDE.md` citation (just "per the workspace convention"); drops the `${GIT_HOME_PUBLIC}/<repo>/<default>/` path-resolution rule in favor of `git worktree list --porcelain` matching on `branch refs/heads/<default>`; --sweep glob description loosened. - infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob. - infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only, not paths. - infra-orchestration/test-e2e: same. - codeql-resolver/README.md: examples annotate the worktree, drop `cd`. The `${GIT_HOME}` / `${GIT_HOME_PUBLIC}` nix-home sessionVariables still exist for workspace tooling — this PR just stops mentioning them in plugin docs where they're not load-bearing. Assisted-by: Claude <noreply@anthropic.com>
JacobPEvans
added a commit
that referenced
this pull request
May 25, 2026
PR #330 swapped hardcoded `~/git/...` for `${GIT_HOME_PUBLIC}/<repo>/...`. Reviewer follow-up: skill docs should not bake a workspace path convention into prose either — describe what to do, not where files live. Changes (10 files): - .claude/rules/worktree-conventions.md: convention table now shows relative paths (`<repo>/main/`, `<repo>/{branch-name}/`). Operational "switch to main and sync" line drops the `cd`, says "From the main worktree, sync". - git-standards/skills/git-workflow-standards/SKILL.md: layout diagram + table use relative paths. Create/Remove commands use `../` from the main worktree. - git-workflows/skills/sync-main: "find and sync main" describes the worktree role; drops `cd`. - git-workflows/skills/troubleshoot-worktree: `git worktree add ../<branch>` (relative). - github-workflows/skills/rebase-pr: "from the main worktree" framing. - github-workflows/skills/refresh-repo: drops the `${GIT_HOME}/CLAUDE.md` citation (just "per the workspace convention"); drops the `${GIT_HOME_PUBLIC}/<repo>/<default>/` path-resolution rule in favor of `git worktree list --porcelain` matching on `branch refs/heads/<default>`; --sweep glob description loosened. - infra-orchestration/orchestrate-infra: "locate each target repo's main worktree" instead of a path glob. - infra-orchestration/sync-inventory: "from the X main worktree" framing; repo list shows names only, not paths. - infra-orchestration/test-e2e: same. - codeql-resolver/README.md: examples annotate the worktree, drop `cd`. The `${GIT_HOME}` / `${GIT_HOME_PUBLIC}` nix-home sessionVariables still exist for workspace tooling — this PR just stops mentioning them in plugin docs where they're not load-bearing. Assisted-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sweep hardcoded
~/git/...references in plugin skills, rules, and READMEs to use the${GIT_HOME_PUBLIC}workspace variable introduced in nix-home v1.23.0.Why
Many skills here (
/sync-main,/refresh-repo,/troubleshoot-worktree,/orchestrate-infra,/sync-inventory, etc.) show path templates that consumers read and adapt. Pre-migration these templates baked in~/git/<repo>/...— post-migration the public/private workspace split is a first-class part of the conventions, and the templates should model it.Files (10)
.claude/rules/worktree-conventions.mdcodeql-resolver/README.mdgit-standards/skills/git-workflow-standards/SKILL.mdgit-workflows/skills/sync-main/SKILL.mdgit-workflows/skills/troubleshoot-worktree/SKILL.mdgithub-workflows/skills/rebase-pr/SKILL.mdgithub-workflows/skills/refresh-repo/SKILL.mdinfra-orchestration/skills/orchestrate-infra/SKILL.mdinfra-orchestration/skills/sync-inventory/SKILL.mdinfra-orchestration/skills/test-e2e/SKILL.md37 hardcoded path occurrences → 37 variable references.
Test plan
~/git/refs in tracked*.md/*.sh/*.yml/*.yaml(verified via grep)Related
GIT_HOME/GIT_HOME_PUBLICsessionVariablesAssisted-by: Claude noreply@anthropic.com