Wip 422 telemetry#258
Merged
Merged
Conversation
Member
Coverage report
This PR does not seem to contain any modification to coverable code. |
damienbfs
reviewed
Apr 9, 2025
| loki_http_port = 13100; | ||
| # loki_grpc_port = 19096; | ||
| otlp_host = "localhost"; | ||
| otlp_grpc_port = 4317; |
Collaborator
There was a problem hiding this comment.
There's some duplicates here (eg. otlp_host and otel_port at line 30).
Collaborator
There was a problem hiding this comment.
Maybe mark these as "Do not change" since the docker compose file uses fixed values. (Also did you use the same values as harcoded in there?)
damienbfs
reviewed
Apr 9, 2025
| # Environment variable available inside devenv | ||
| env = { | ||
| GREET = "Lomas env"; | ||
| TELEMETRY = 1; |
damienbfs
reviewed
Apr 9, 2025
| scripts.pip-fix.exec = '' | ||
| pushd $DEVENV_ROOT | ||
| uv pip compile pyproject.toml --annotation-style line --all-extras -o requirements.txt | ||
| uv pip compile pyproject.toml --annotation-style line --all-extras $@ | ${pkgs.gnused}/bin/sed -re '/^-e file:/d' > requirements.txt |
damienbfs
reviewed
Apr 9, 2025
| } | ||
| ]; | ||
| }; | ||
| # cheeky override of postgres statup command to force a aclean start |
damienbfs
reviewed
Apr 9, 2025
| ${config.scripts.ut.exec} | ||
| ''; | ||
|
|
||
| scripts.yelp.exec = '' |
Collaborator
There was a problem hiding this comment.
Nice!
Can we update the doc with this? I think it would be CONTRIBUTING.md and server/CONTRIBUTING.md. Otherwise we can also do it in another pr.
bstuder
force-pushed
the
wip_422_telemetry
branch
from
6025ef5 to
a30028a
Compare
bstuder
force-pushed
the
wip_422_telemetry
branch
from
89772a6 to
0872ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add telemetry elements: loki/tempo/grafana/otlp-collector