CSVW-SAFE Implementation#357
Merged
PaulineMauryL merged 20 commits intodevelopfrom Apr 15, 2026
Merged
Conversation
PaulineMauryL
changed the title
PaulineMauryL
force-pushed
the
metadata_extension
branch
2 times, most recently
from
38c381d to
8dfae30
Compare
PaulineMauryL
force-pushed
the
metadata_extension
branch
from
b4ab670 to
f9eea27
Compare
Member
Author
Coverage report
Click to see where and how coverage changed
The report is truncated to 25 files out of 34. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
I plan to put csvw-safe in pypi after documenting it and then I will modify the imports requirements. |
bstuder
force-pushed
the
metadata_extension
branch
from
f9eea27 to
e4607be
Compare
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
| lomas-core = { workspace = true } | ||
| lomas-client = { workspace = true } | ||
| lomas-server = { workspace = true } | ||
| csvw-safe = { git = "https://github.com/dscc-admin-ch/csvw-safe.git", subdirectory = "csvw-safe-library", rev = "add_column_group_invariance" } |
Collaborator
There was a problem hiding this comment.
As you mentioned this is pypa-blocking right ?
Member
Author
There was a problem hiding this comment.
yes I think that's why the push to Pypi workflow fails. I think it will work once the other library is on pypi and I remove it from here (i just want to do the documentation before uploading to pypi)
Member
Author
There was a problem hiding this comment.
here it is: https://pypi.org/project/csvw-safe/0.0.1/
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
bstuder
reviewed
Apr 9, 2026
LancelotMarti
approved these changes
Apr 10, 2026
Collaborator
LancelotMarti
left a comment
LancelotMarti
left a comment
There was a problem hiding this comment.
Very nice PR! Thanks :)
bstuder
approved these changes
Apr 13, 2026
Collaborator
bstuder
left a comment
bstuder
left a comment
There was a problem hiding this comment.
LGTM (waiting on @csvw-safe/ release and 👍 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for testing, not open PR