Skip to content

Conversation

@stehlih
Copy link
Contributor

@stehlih stehlih commented Feb 23, 2023

Pull Request

Added

  • AddsDomainController:
    • add UnprotectFromAccidentalDeletion to allow dc promote if an existing AD computer account is protected
  • DhcpServerAuthorization:
    • new resource to authorize DHCP server in AD
  • FailoverCluster:
    • add Networks support
    • add installation of required Windows Features
    • update documentation

Changed

  • DHCPServer:
    • fix EnableSecurityGroups if resource is not running on a domain controller
  • HyperV:
    • remove unused code after migration to HyperVDsc

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

    * fix EnableSecurityGroups if resource is not running on a domain controller

- DhcpServerAuthorization:
    * new resource to authorize DHCP server in AD

- FailoverCluster:
    * add Networks support
    * add installation of required Windows Features
    * update documentation

- HyperV:
    * remove unused code after migration to HyperVDsc

- AddsDomainController:
    * add UnprotectFromAccidentalDeletion to allow dc promote if an existing AD computer account is protected
@nyanhp nyanhp merged commit 56a6910 into dsccommunity:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants