Pester Test file created, one test fails#1
Pester Test file created, one test fails#1SimonWahlin wants to merge 4 commits intodsccommunity:devfrom SimonWahlin:dev
Conversation
… domain flat name correctly
|
Hi @SimonWahlin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
This is awesome! Would you like to fix it? |
|
@SimonWahlin, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
This looks great. We need tho tests passing before we can merge the request. If you don't plan on fixing the failure, you can comment out the broken test, open an issue. |
|
FYI, Contribution Guidelines say not to change the version number. |
|
I closed this Request and added a new one just with the tests. |
Test-TargetResource returning non-boolean value.
xComputer: Added Description Property
* BREAKING CHANGE- Converted all xScheduledTask Interval/Duration type parameters over to be string format * Fix parameter mismatch * Change AppVeyor Environment * Fixed xScheduledTask Integration tests to run on older OS * Improve test coverage * BREAKING CHANGE- Converted all xScheduledTask Interval/Duration type parameters over to be string format * Fix parameter mismatch * Change AppVeyor Environment * Fixed xScheduledTask Integration tests to run on older OS * Improve test coverage * Added support for setting repetition duration to Indefinitely. * BREAKING CHANGE- Converted all xScheduledTask Interval/Duration type parameters over to be string format Fix parameter mismatch Change AppVeyor Environment Fixed xScheduledTask Integration tests to run on older OS Improve test coverage BREAKING CHANGE- Converted all xScheduledTask Interval/Duration type parameters over to be string format Fix parameter mismatch Change AppVeyor Environment Fixed xScheduledTask Integration tests to run on older OS Improve test coverage * Added support for setting repetition duration to Indefinitely. * Correct examples * Fix up tests * Added more verbose message to try and identify problem in V4 * Fix problems in creating triggers * Rewriting trigger repetition code * Another fix for WS2012 * Add some info to help debug test failures * More changes for testing * Another attempt at fixing WS2012R2 * One more try * Final fix up of Scheduled Task * Final tweaks
Changes needed to pass HQRM tests and initiade the reosurce in a simple unit test
4 participants
Pester Test file created, one test fails since resource doesnt handle domain flat name correctly.
The Test-TargetResource splits the actual and specified domain names on '.' and compares the arrays. This assumes that the Domain Flat NetBios name is the first part of the FQDN. Since this isn't a requirement the resource should compare given domain name with both domain FQDN and the actual Flat NetBios name instead.