Convert xComputer to HQRM and move strings to Localization File - Fixes #101

[PlagueHO]

Pull Request (PR) description
Convert xComputer resource to HQRM standards and move strings to Localization file.

This Pull Request (PR) fixes the following issues:

• Fixes Convert xComputer to HQRM and move strings to Localization File #101
• Work on Convert all resources to HQRM #94
• Work on Move all message & exception strings to Localization Files #80

Task list:

• Change details added to Unreleased section of CHANGELOG.md?
• Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

@johlju - would you mind reviewing if you get time?

---

This change is 

[codecov-io]

Codecov Report

Merging #102 into dev will increase coverage by 2%.
The diff coverage is 77%.

@@        Coverage Diff         @@
##           dev   #102   +/-   ##
==================================
+ Coverage   80%    83%   +2%     
==================================
  Files        6      6           
  Lines      688    693    +5     
==================================
+ Hits       555    576   +21     
+ Misses     133    117   -16

[johlju]

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 1 at r1 (raw file):

[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidGlobalVars", "", Scope = "Function")]

Single quotes

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 442 at r1 (raw file):

    )

    Write-Verbose -Message ($script:localizedData.TestingComputerStateMessage -f $Name)

This row seems unnecessary, because the text is almost identical to the row below.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 493 at r1 (raw file):

        catch
        {
            Write-Verbose -Message ($script:localizedData.CheckingNotDomainMemberMessage -f $DomainName)

This localized string does not take any arguments.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 548 at r1 (raw file):

Net Bios

NetBIOS

---

Tests/Unit/MSFT_xComputer.Tests.ps1, line 157 at r1 (raw file):

$Env:ComputerName

$env:COMPUTERNAME

Throughout.

---

Tests/Unit/MSFT_xComputer.Tests.ps1, line 866 at r1 (raw file):

"ThisNameIsTooLong"

Single quotes. Throughout. (but only seen it here and below)

---

Comments from Reviewable

[PlagueHO]

All done! Thanks @johlju

---

Review status: 6 of 9 files reviewed at latest revision, 6 unresolved discussions.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 1 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 442 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This row seems unnecessary, because the text is almost identical to the row below.

Done.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 493 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This localized string does not take any arguments.

Good catch! Done.

---

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1, line 548 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Net Bios

NetBIOS

Done.

---

Tests/Unit/MSFT_xComputer.Tests.ps1, line 157 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$Env:ComputerName

$env:COMPUTERNAME

Throughout.

Done.

---

Tests/Unit/MSFT_xComputer.Tests.ps1, line 866 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

"ThisNameIsTooLong"

Single quotes. Throughout. (but only seen it here and below)

Done.

---

Comments from Reviewable

[johlju]

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable