Skip to content

Fix ExecutionTimeLimit to Enable No Limit - Fixes #115#118

Merged
PlagueHO merged 6 commits into
dsccommunity:devfrom
PlagueHO:Issue-115
Dec 12, 2017
Merged

Fix ExecutionTimeLimit to Enable No Limit - Fixes #115#118
PlagueHO merged 6 commits into
dsccommunity:devfrom
PlagueHO:Issue-115

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Dec 7, 2017

Pull Request (PR) description
This PR enables setting the ExecutionTimeLimit to no limit (indefinite) by setting the parameter to '00:00:00'. Note: setting ExecutionTimeLimit has to be done differently on Windows Server 2012 R2 and Windows Server 2016/Windows 10, so I've added code to handle them all.

This Pull Request (PR) fixes the following issues:
#115

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - if you wouldn't mind and have the time would you be able to review?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Dec 7, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 7, 2017

Codecov Report

Merging #118 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #118    +/-   ##
===================================
+ Coverage   83%    83%   +<1%     
===================================
  Files        6      6            
  Lines      709    711     +2     
===================================
+ Hits       590    593     +3     
+ Misses     119    118     -1

@johlju
Copy link
Copy Markdown
Member

johlju commented Dec 10, 2017

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xScheduledTask.Tests.ps1, line 749 at r1 (raw file):

-Times 1

Maybe -Exactly -Times 1? If you only want them to happen once.


Comments from Reviewable

@PlagueHO
Copy link
Copy Markdown
Member Author

@johlju - all done! Thanks for reviewing as always!


Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion.


Tests/Unit/MSFT_xScheduledTask.Tests.ps1, line 749 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-Times 1

Maybe -Exactly -Times 1? If you only want them to happen once.

I made the correction to all in the file.


Comments from Reviewable

@johlju
Copy link
Copy Markdown
Member

johlju commented Dec 11, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@PlagueHO
Copy link
Copy Markdown
Member Author

Hi @johlju - I fixed the merge conflicts. Could you sign the last file off again? Thank you!

@johlju
Copy link
Copy Markdown
Member

johlju commented Dec 12, 2017

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@PlagueHO
Copy link
Copy Markdown
Member Author

Thanks @johlju


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@PlagueHO PlagueHO merged commit 286ae32 into dsccommunity:dev Dec 12, 2017
@joeyaiello joeyaiello removed the needs review The pull request needs a code review. label Dec 12, 2017
@PlagueHO PlagueHO deleted the Issue-115 branch December 12, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants