Fix ExecutionTimeLimit to Enable No Limit - Fixes #115#118
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #118 +/- ##
===================================
+ Coverage 83% 83% +<1%
===================================
Files 6 6
Lines 709 711 +2
===================================
+ Hits 590 593 +3
+ Misses 119 118 -1 |
|
Reviewed 6 of 6 files at r1. Tests/Unit/MSFT_xScheduledTask.Tests.ps1, line 749 at r1 (raw file):
Maybe Comments from Reviewable |
|
@johlju - all done! Thanks for reviewing as always! Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion. Tests/Unit/MSFT_xScheduledTask.Tests.ps1, line 749 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
I made the correction to all in the file. Comments from Reviewable |
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
|
Hi @johlju - I fixed the merge conflicts. Could you sign the last file off again? Thank you! |
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
|
Thanks @johlju Review status: Comments from Reviewable |
Pull Request (PR) description
This PR enables setting the ExecutionTimeLimit to no limit (indefinite) by setting the parameter to '00:00:00'. Note: setting ExecutionTimeLimit has to be done differently on Windows Server 2012 R2 and Windows Server 2016/Windows 10, so I've added code to handle them all.
This Pull Request (PR) fixes the following issues:
#115
Task list:
@johlju - if you wouldn't mind and have the time would you be able to review?
This change is