Skip to content

Add the ability to specify an OU upon Domain Join#13

Merged
tysonjhayes merged 9 commits intodsccommunity:devfrom
mprahl:JoinOuProperty
Jan 5, 2016
Merged

Add the ability to specify an OU upon Domain Join#13
tysonjhayes merged 9 commits intodsccommunity:devfrom
mprahl:JoinOuProperty

Conversation

@mprahl
Copy link
Copy Markdown
Contributor

@mprahl mprahl commented Oct 20, 2015

No description provided.

@msftclas
Copy link
Copy Markdown

Hi @PrahlM93, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

@PrahlM93, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mprahl mprahl mentioned this pull request Oct 20, 2015
Comment thread Tests/xComputermanagement.Tests.ps1 Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add the new keys to this statement.

@mprahl
Copy link
Copy Markdown
Contributor Author

mprahl commented Oct 23, 2015

@tysonjhayes Any other suggestions?

@tysonjhayes
Copy link
Copy Markdown

Nothing that needs to be handled in this PR, I'd like to see the verb-noun changed for everything but that's out of scope for this. 😁

Looks good to me though, thanks!

@tysonjhayes
Copy link
Copy Markdown

@TravisEz13 @KarolKaczmarek either one of you able to lend a hand by merging this so I can close out #6 ?

@mprahl
Copy link
Copy Markdown
Contributor Author

mprahl commented Dec 21, 2015

@tysonjhayes, is there any news on whether or not this will be merged?

@MCrank
Copy link
Copy Markdown

MCrank commented Jan 2, 2016

@tysonjhayes I too would like for this to get merged. Surprised this was not included initially.

tysonjhayes pushed a commit that referenced this pull request Jan 5, 2016
Add the ability to specify an OU upon Domain Join
@tysonjhayes tysonjhayes merged commit d715779 into dsccommunity:dev Jan 5, 2016
@tysonjhayes
Copy link
Copy Markdown

Sorry about the delay here guys. This is now merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants