Correct Example Style to meet HQRM and Enable Example Tests - Fixes #82#86
Correct Example Style to meet HQRM and Enable Example Tests - Fixes #82#86PlagueHO merged 8 commits intodsccommunity:devfrom
Conversation
|
I did not style check the examples in README.md. Since you will remove them. Why not remove them now and add an Examples header instead pointing to the Examples folder? Reviewed 16 of 16 files at r1. Examples/xOfflineDomainJoin/1-JoinDomainUsingODJBlob.ps1, line 17 at r1 (raw file):
Examples/xVirtualMemory/1-SetVirtualMemory.ps1, line 21 at r1 (raw file):
Single quotes, here and the three lines below. Comments from Reviewable |
|
Thanks for reviewing @johlju! I've moved all the examples out of the README.MD and replaced them with links - I also moved the example links to be under the resource header they actually apply to. While I was at it I found some spelling errors in the filenames and corrected those. Review status: 8 of 13 files reviewed at latest revision, 2 unresolved discussions. Examples/xOfflineDomainJoin/1-JoinDomainUsingODJBlob.ps1, line 17 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Examples/xVirtualMemory/1-SetVirtualMemory.ps1, line 21 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. And aligned. Comments from Reviewable |
|
Reviewed 1 of 18 files at r1, 7 of 7 files at r2. Comments from Reviewable |
|
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
Thanks for reviewing @johlju |
This PR:
Common Tests - Validate Example Files.Common Tests - Validate Example Filestests.Note: I could instead link the examples in README.MD instead of keeping copies in there, but as these will very soon be removed anyway due to the move to auto-documentation I didn't bother, as they get automatically assembled anyway.
This change is