Issue#13 - Update all DSC resources Test-TargetResource to return $false when file being manged does not exist.#14
Merged
PlagueHO merged 6 commits intodsccommunity:devfrom Aug 5, 2018
Conversation
If file does not exist Test-TargetResouce will return $false Updated tests.
So Test-TargetResource return $false if file being managed doesn't exist
Codecov Report
@@ Coverage Diff @@
## dev #14 +/- ##
==================================
+ Coverage 99% 99% +<1%
==================================
Files 3 3
Lines 177 192 +15
==================================
+ Hits 176 191 +15
Misses 1 1 |
Member
|
Awesome stuff @jcwalker - it's getting late here so I'll get the review done tomorrow. |
PlagueHO
approved these changes
Aug 5, 2018
Member
PlagueHO
left a comment
PlagueHO
left a comment
There was a problem hiding this comment.
Really great job @jcwalker !
Reviewed 6 of 9 files at r2, 1 of 1 files at r3, 1 of 2 files at r4, 3 of 3 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Refactored Test-TargetResouce in all DSC resource to return $false if the file being managed doesn't exist. This changes the behavior to create the file instead of throwing
This Pull Request (PR) fixes the following issues:
Fixes #13
Task list:
This change is