Skip to content

Correct Configuration Names in Example files - Fixes #15#16

Merged
PlagueHO merged 1 commit intodevfrom
Issue-15
Aug 7, 2018
Merged

Correct Configuration Names in Example files - Fixes #15#16
PlagueHO merged 1 commit intodevfrom
Issue-15

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Aug 6, 2018

Pull Request (PR) description
This PR corrects the configuration names in the Example files to match the filename of the configuration, sans the numeric prefix.

This Pull Request (PR) fixes the following issues:

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - would you mind reviewing when you have a moment?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Aug 6, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2018

Codecov Report

Merging #16 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #16   +/-   ##
=================================
  Coverage   99%   99%           
=================================
  Files        3     3           
  Lines      192   192           
=================================
  Hits       191   191           
  Misses       1     1

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 3ee18f2 into dev Aug 7, 2018
@PlagueHO PlagueHO deleted the Issue-15 branch August 7, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Configuration Names in Examples

2 participants