Skip to content

Change IniSettingsFile unit tests to be non-destructive - Fixes #22#23

Merged
PlagueHO merged 3 commits intodevfrom
Issue-22
Sep 28, 2018
Merged

Change IniSettingsFile unit tests to be non-destructive - Fixes #22#23
PlagueHO merged 3 commits intodevfrom
Issue-22

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Sep 28, 2018

Pull Request (PR) description

This PR corrects unit tests to make sure they're not destructive. It also opts in to additional common tests and updates to the new MIT license format.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me? I just want to get this one out before I release to the PS Gallery.


This change is Reviewable

@PlagueHO PlagueHO changed the title Fixes #22 Change IniSettingsFile unit tests to be non-destructive - Fixes #22 Sep 28, 2018
@PlagueHO PlagueHO self-assigned this Sep 28, 2018
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Sep 28, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2018

Codecov Report

Merging #23 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #23   +/-   ##
=================================
  Coverage   91%   91%           
=================================
  Files        5     5           
  Lines      246   246           
=================================
  Hits       224   224           
  Misses      22    22

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@PlagueHO
Copy link
Copy Markdown
Member Author

Thank you @johlju !!!!

@PlagueHO PlagueHO merged commit b9ffb81 into dev Sep 28, 2018
@PlagueHO PlagueHO deleted the Issue-22 branch September 28, 2018 07:22
@johlju
Copy link
Copy Markdown
Member

johlju commented Sep 28, 2018

@PlagueHO Your welcome! 😃 Hoping the publishing will work as expected. 😉

@PlagueHO
Copy link
Copy Markdown
Member Author

@johlju - We will see 😁 I've hooked up my gallery_api environment variable in AppVeyor so fingers crossed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TestFile.txt From Repo

2 participants