Skip to content

Add .VSCode Settings for PSScriptAnalyzer Rules - Fixes #25#26

Merged
PlagueHO merged 1 commit intodevfrom
Issue-25
Sep 30, 2018
Merged

Add .VSCode Settings for PSScriptAnalyzer Rules - Fixes #25#26
PlagueHO merged 1 commit intodevfrom
Issue-25

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Sep 29, 2018

Pull Request (PR) description

Added .VSCode settings for applying DSC PSSA rules

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - another minor one for you! 😁 Thank you again!


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Sep 29, 2018
@PlagueHO PlagueHO self-assigned this Sep 29, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2018

Codecov Report

Merging #26 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #26   +/-   ##
=================================
  Coverage   91%   91%           
=================================
  Files        5     5           
  Lines      246   246           
=================================
  Hits       224   224           
  Misses      22    22

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@PlagueHO PlagueHO merged commit 162df55 into dev Sep 30, 2018
@PlagueHO PlagueHO deleted the Issue-25 branch September 30, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .VSCode Settings for PSScriptAnalyzer Rules

2 participants