Skip to content

Complete transfer of ownership - Fixes #39#40

Merged
PlagueHO merged 2 commits intodsccommunity:devfrom
PlagueHO:Issue-39
Dec 25, 2019
Merged

Complete transfer of ownership - Fixes #39#40
PlagueHO merged 2 commits intodsccommunity:devfrom
PlagueHO:Issue-39

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Dec 1, 2019

Pull Request (PR) description

This PR completes the transfer of ownership of the module to the DSC Community by updating all licenses and references.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@gaelcolas - would you mind reviewing?


This change is Reviewable

@PlagueHO PlagueHO requested a review from gaelcolas December 1, 2019 00:19
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Dec 1, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2019

Codecov Report

Merging #40 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #40   +/-   ##
=================================
  Coverage   69%   69%           
=================================
  Files        4     4           
  Lines      452   452           
=================================
  Hits       314   314           
  Misses     138   138

@PlagueHO
Copy link
Copy Markdown
Member Author

@gaelcolas - can you review this one? I'd like to have it through before I migrate it to the new structure.

Copy link
Copy Markdown
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Member

@gaelcolas gaelcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 8d1dfdc into dsccommunity:dev Dec 25, 2019
@PlagueHO PlagueHO deleted the Issue-39 branch December 25, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Transfer of Ownership

3 participants