Skip to content

FileSystemDsc: Fix GitVersion#14

Merged
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/gitversion
Jan 23, 2021
Merged

FileSystemDsc: Fix GitVersion#14
johlju merged 1 commit intodsccommunity:mainfrom
johlju:fix/gitversion

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Jan 23, 2021

Pull Request (PR) description

  • FileSystemDsc
    • The component gitversion that is used in the pipeline was wrongly configured
      when the repository moved to the new default branch main. It no longer throws
      an error when using newer versions of GitVersion.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jan 23, 2021
Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a95d107). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             main    #14   +/-   ##
=====================================
  Coverage        ?   100%           
=====================================
  Files           ?      1           
  Lines           ?    155           
  Branches        ?      0           
=====================================
  Hits            ?    155           
  Misses          ?      0           
  Partials        ?      0           

@johlju johlju merged commit cc78d43 into dsccommunity:main Jan 23, 2021
@johlju johlju deleted the fix/gitversion branch January 23, 2021 17:15
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jan 23, 2021
johlju added a commit to johlju/FileSystemDsc that referenced this pull request Feb 9, 2021
- FileSystemDsc
  - The component `gitversion` that is used in the pipeline was wrongly configured
    when the repository moved to the new default branch `main`. It no longer throws
    an error when using newer versions of GitVersion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant