Skip to content

Fix Integration Tests#534

Merged
johlju merged 19 commits into
dsccommunity:mainfrom
dan-hughes:Integration-test-fixes
Jun 2, 2025
Merged

Fix Integration Tests#534
johlju merged 19 commits into
dsccommunity:mainfrom
dan-hughes:Integration-test-fixes

Conversation

@dan-hughes
Copy link
Copy Markdown
Contributor

@dan-hughes dan-hughes commented Mar 17, 2025

Pull Request (PR) description

Fix failing integration tests on Server 2022.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (c165bcc) to head (eed18b3).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #534   +/-   ##
===================================
- Coverage    97%    97%   -1%     
===================================
  Files        27     27           
  Lines      1886   1886           
===================================
- Hits       1846   1845    -1     
- Misses       40     41    +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dan-hughes dan-hughes changed the title Fix Server 2022 Integration Tests Fix Integration Tests Apr 14, 2025
@dan-hughes dan-hughes force-pushed the Integration-test-fixes branch from 2f24a97 to 645c914 Compare May 12, 2025 06:47
@johlju
Copy link
Copy Markdown
Member

johlju commented May 14, 2025

@dan-hughes is this one ready for review?

@dan-hughes
Copy link
Copy Markdown
Contributor Author

No, I need to keep triggering a test run until it fails as it seems difficult to reproduce. Can do an pipeline run?

@johlju
Copy link
Copy Markdown
Member

johlju commented May 14, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@dan-hughes dan-hughes marked this pull request as ready for review May 24, 2025 16:08
@dan-hughes
Copy link
Copy Markdown
Contributor Author

@johlju, looks to be working on two builds now. Hard one to reproduce.

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)

@johlju johlju merged commit 6570592 into dsccommunity:main Jun 2, 2025
9 checks passed
@dan-hughes dan-hughes deleted the Integration-test-fixes branch June 2, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent Integration Test Failures on Windows Server 2022

2 participants