Fix Integration Tests#534
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
===================================
- Coverage 97% 97% -1%
===================================
Files 27 27
Lines 1886 1886
===================================
- Hits 1846 1845 -1
- Misses 40 41 +1 🚀 New features to boost your workflow:
|
2f24a97 to
645c914
Compare
Member
|
@dan-hughes is this one ready for review? |
Contributor
Author
|
No, I need to keep triggering a test run until it fails as it seems difficult to reproduce. Can do an pipeline run? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@johlju, looks to be working on two builds now. Hard one to reproduce. |
…s/NetworkingDsc into Integration-test-fixes
johlju
approved these changes
Jun 2, 2025
Member
johlju
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dan-hughes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fix failing integration tests on Server 2022.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is