-
Notifications
You must be signed in to change notification settings - Fork 227
Switch copilot workflow to Linux #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@johlju has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe GitHub Actions workflow for setting up the SqlServerDsc Copilot environment was updated to run on an Ubuntu runner instead of Windows. The PowerShell execution policy setting was removed, and the installation steps were expanded to include the DSCv3 executable with verification. The method for listing DSC resources was changed to use the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
.github/workflows/copilot-setup-steps.yml (2)
55-58:dotnet-gitversionlikely unavailable in later steps
dotnet tool install --globalplaces the tool in~/.dotnet/tools, a directory not on PATH in subsequent GitHub Actions steps on Linux. The next step (Verify GitVersion) will therefore fail with “command not found”.Add the path explicitly for the rest of the job:
- name: Install .NET Tools shell: pwsh run: | dotnet tool install --global GitVersion.Tool --version 5.* echo "${HOME}/.dotnet/tools" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
74-75: Back-slash in dot-sourced script path breaks on Linux
.\build.ps1(and.\in general) is only valid on Windows. On Linux it is treated as a literal filename beginning with a back-slash and the script is not found. Replace with the Unix-friendly form (works on both platforms):-.\build.ps1 -ResolveDependency -Tasks 'noop' -ErrorAction Stop +./build.ps1 -ResolveDependency -Tasks 'noop' -ErrorAction Stop -.\build.ps1 -Tasks 'build' -ErrorAction Stop +./build.ps1 -Tasks 'build' -ErrorAction Stop -.\build.ps1 -Tasks 'noop' +./build.ps1 -Tasks 'noop'Also applies to: 84-84, 100-100
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/copilot-setup-steps.yml(1 hunks)CHANGELOG.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.md
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.md: Line length in Markdown files should be wrapped after a word when a line exceeds 80 characters.
Use 2 spaces for indentation in Markdown files.
Files:
CHANGELOG.md
🧠 Learnings (1)
📚 Learning: applies to tests/integration/commands/*.integration.tests.ps1 : all integration tests must use the p...
Learnt from: CR
PR: dsccommunity/SqlServerDsc#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-01T12:29:39.352Z
Learning: Applies to tests/Integration/Commands/*.Integration.Tests.ps1 : All integration tests must use the provided code block prior to the first Describe block to set up the integration test environment and ensure the module being tested is available.
Applied to files:
.github/workflows/copilot-setup-steps.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: dsccommunity.SqlServerDsc (Build Package Module)
- GitHub Check: PSScriptAnalyzer
🔇 Additional comments (1)
.github/workflows/copilot-setup-steps.yml (1)
25-25: Switching toubuntu-latest– double-check Windows-specific assumptionsThe rest of the job still assumes a Windows‐style environment (e.g.,
\path separators, dot-sourcing with.\script.ps1, SQL Server-centric DSC build/test logic). None of these are guaranteed to work on Linux without adjustments or additional dependencies (SQL Server binaries, xplat DSC resources, etc.). Please run a dry-run on an Ubuntu runner to ensure every step succeeds.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is