Skip to content

Added 'defragsvc' service conflict known issue to README.MD for Disk - Fixes #172#173

Merged
PlagueHO merged 1 commit intodsccommunity:devfrom
PlagueHO:Issue-172
Sep 25, 2018
Merged

Added 'defragsvc' service conflict known issue to README.MD for Disk - Fixes #172#173
PlagueHO merged 1 commit intodsccommunity:devfrom
PlagueHO:Issue-172

Conversation

@PlagueHO
Copy link
Copy Markdown
Member

@PlagueHO PlagueHO commented Sep 21, 2018

Pull Request (PR) description

This PR Documents the Disk known issue when the 'defragsvc' is started.

I didn't add tests because in my experimentation, this issue does not always 100% happen (it seems to depend on the disk and whether the service is doing work at the time).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you get a chance?


This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #173 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #173   +/-   ##
==================================
  Coverage   94%    94%           
==================================
  Files        6      6           
  Lines      797    797           
==================================
  Hits       756    756           
  Misses      41     41

Copy link
Copy Markdown
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 24, 2018
@PlagueHO
Copy link
Copy Markdown
Member Author

Thanks @johlju !!!!

@PlagueHO PlagueHO merged commit 37f6540 into dsccommunity:dev Sep 25, 2018
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Sep 25, 2018
@PlagueHO PlagueHO deleted the Issue-172 branch September 25, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple Formatting Drive Failing via StorageDsc 4.1.0.0

3 participants