Skip to content

Updated FileSystemACL Set #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwirkykat merged 3 commits into from
Nov 10, 2017
Merged

Updated FileSystemACL Set #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f7822e
Updated FilSystemACL Set
Dec 6, 2016
193214e
Updated pester tests to include mock for new get acl access function
Apr 14, 2017
e5a7039
Fixed Mocks to xFileSystemAccess
Apr 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion DSCResources/MSFT_xFileSystemAccessRule/MSFT_xFileSystemAccessRule.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ function Set-TargetResource
throw "Unable to get ACL for '$Path' as it does not exist"
}

$acl = Get-Acl -Path $Path
$acl = Get-ACLAccess -Path $Path
$accessRules = $acl.Access

if ($Ensure -eq "Present")
Expand Down Expand Up @@ -230,5 +230,9 @@ function Test-TargetResource

return $true
}
Function Get-ACLAccess($Path)
{
return (Get-Item -Path $Path).GetAccessControl('Access')
}

Export-ModuleMember -Function *-TargetResource
31 changes: 31 additions & 0 deletions Tests/Unit/MSFT_xFileSystemAccessRule.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ try
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

Mock Get-ACLAccess {
return @{
Access = @()
} | Add-Member -MemberType ScriptMethod -Name "SetAccessRule" -Value {} -PassThru `
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

It "should return absent from the get method" {
(Get-TargetResource @testParams).Ensure | Should Be "Absent"
}
Expand Down Expand Up @@ -70,6 +77,18 @@ try
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

Mock Get-ACLAccess {
return @{
Access = @(
@{
IdentityReference = $testParams.Identity
FileSystemRights = [System.Security.AccessControl.FileSystemRights]::FullControl
}
)
} | Add-Member -MemberType ScriptMethod -Name "SetAccessRule" -Value {} -PassThru `
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

It "should return present from the get method" {
(Get-TargetResource @testParams).Ensure | Should Be "Present"
}
Expand Down Expand Up @@ -129,6 +148,18 @@ try
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

Mock Get-ACLAccess {
return @{
Access = @(
@{
IdentityReference = $testParams.Identity
FileSystemRights = [System.Security.AccessControl.FileSystemRights]::FullControl
}
)
} | Add-Member -MemberType ScriptMethod -Name "SetAccessRule" -Value {} -PassThru `
| Add-Member -MemberType ScriptMethod -Name "RemoveAccessRule" -Value {} -PassThru
}

It "should return present from the get method" {
(Get-TargetResource @testParams).Ensure | Should Be "Present"
}
Expand Down