Merged
Conversation
dschep
reviewed
Sep 25, 2017
Owner
dschep
left a comment
dschep
left a comment
There was a problem hiding this comment.
Looking good. In addition to the extras notes, add yourself to the Contributors list! 😃
| * ``username`` - login username | ||
| * ``password`` - login password | ||
| * ``room`` - room/channel name to post in | ||
|
|
Owner
There was a problem hiding this comment.
Add a note here about having to install as pip install ntfy[rocketchat] and add it to the extras list above (see Slack for an example)
Contributor
Author
There was a problem hiding this comment.
All done. Thanks.
5 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a backend for Rocket.Chat. Configuration settings can be found in the documentation.
Thanks in advance!