added deep clone to _allAttributes to prevent changes in the original…#16
Merged
dschu012 merged 1 commit intodschu012:masterfrom Apr 29, 2021
Merged
Conversation
… magic_attributes
This was referenced Apr 27, 2021
Owner
|
Looks good to me. Thanks for looking into all these different things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request to address #10.
As mentioned in the issue this is just a proposed solution and only the simplest way possible to fix this. Maybe this should be addressed in another way, but that should be discussed beforehand. I will adopt the pull request accordingly.