Closed
Conversation
…ead and write function for items
dschu012
reviewed
Apr 29, 2021
| let min = Math.floor((values[0] * values[2]) / 256); | ||
| let max = Math.floor((values[1] * values[2]) / 256); | ||
| let seconds = Math.floor(values[2] / 25); | ||
| values = [min, max, seconds]; |
Owner
There was a problem hiding this comment.
I think an issue w/ doing it here is I am trying to mirror the output of https://github.com/nokka/d2s, because I have a plugin for the slashdiablo armory that will take their jsons (from his library) and create a d2s from it. So if I were to write a save w/ this change I'd think the new save would get the wrong values for psn dmg.
Merged
Contributor
Author
|
This is included in #31 so I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12, still marked as draft as discussion may be necessary.