Conversation
Owner
dsidirop
commented
Jun 2, 2024
dsidirop
commented
- docs (api.lua): trivial doc-comment tweaks
- perf (unitframes.lua): optimize BuffOnUpdate() a bit by avoiding to call GetTime() twice
- perf (unitframes.lua): BuffOnUpdate now calls pfUI.api.GetPlayerBuffX(this.id,"HELPFUL")
- perf (unitframes.lua): DebuffOnUpdate() now snapshots GetTime() once at the top of the call
- perf (unitframes.lua): DebuffOnUpdate() now calls GetPlayerBuffX() just once
- perf (unitframes.lua): call pfUI.api.GetPlayerBuffX(i,"HELPFUL") once in the 'buffs' section of :RefreshUnit()
- perf (unitframes.lua): call pfUI.api.GetPlayerBuffX(i,"HELPFUL") once per iteration inside the 'debuff' section of :RefreshUnit()
- perf (unitframes.lua): move the declaration of the 'row' variable outside the for-each-debuff loop of :RefreshUnit()
…all GetTime() twice
…(this.id,"HELPFUL")
…at the top of the call
… in the 'buffs' section of :RefreshUnit()
… per iteration inside the 'debuff' section of :RefreshUnit()
…side the for-each-debuff loop of :RefreshUnit()
dsidirop
deleted the
dsidirop/6-consolidate-getplayerbuff-into-an-api-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.