Separate config from code #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephChataignon
force-pushed
the
Separate-config-from-code
branch
from
180bc83 to
9a5f86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big reorganization to separate the configuration from the code. The config now sits in 3 places:
.envfor sensitive (API keys) and deployment-specific (database path) variablesembedding_config.yamlfor settings related to the vector DB creationllm_config.yamlfor settings related to running LLM inferenceThe gitignore and readme files have been updated accordingly, as well as the loading of config variables in the whole codebase. Example files for each of the 3 config files are provided. I have tested that it runs with these changes of course.
IMPORTANT: this will break the way the config is currently loaded. Make sure to save your config before pulling, and re-set your config according to the new organisation afterward.